Generalized Test Functionality for pynxtools
plugins¶
The pynxtools
sub-package testing
is to be utilized to write automated tests for pynxtools reader plugins without requiring in-depth knowledge of the pynxtools internal architecture. The tool supports generalised a general test for all reader plugins, irrespective of the technical details of the raw data files and the internal design of the plugin (note: it is assumed that the plugin was built from the plugin template or has the same structure internally).
Why it is needed¶
To test integration of a plugin with the pynxtools
core system, we need to:
1. Test the plugin's integration with pynxtools
from the plugin's CI/CD.
2. Test in the pynxtools's CI/CD if the plugin has been integrated with pynxtools
properly.
How to write an integration test for a reader plugin with pynxtools.testing
¶
It is very simple to write a test to verify the plugin integration with pynxtools
within the plugin's tests directory. The developer can place the test where they want, but they need to use the provided test interface from pynxtools
. An example test for pynxtools-FOO
(a demo plugin) plugin is given below:
import os
import pytest
from pynxtools.testing.nexus_conversion import ReaderTest
# e.g. module_dir = /pynxtools-foo/tests
module_dir = os.path.dirname(os.path.abspath(__file__))
@pytest.mark.parametrize(
"nxdl,reader_name,files_or_dir",
[
("NXfoo", "foo", f"{module_dir}/../tests/data/test_data_dir_1"),
("NXfoo", "foo", f"{module_dir}/../tests/data/test_data_dir_2")
],
)
def test_foo_reader(nxdl, reader_name, files_or_dir, tmp_path, caplog):
"""Test for the FooReader or foo reader plugin.
Parameters
----------
nxdl : str
Name of the NXDL application definition that is to be tested by
this reader plugin (e.g. NXfoo), without the file ending .nxdl.xml.
reader_name : str
Name of the class of the reader (e.g. "foo")
files_or_dir : class
Name of the class of the reader.
tmp_path : pytest.fixture
Pytest fixture variable, used to create temporary file and clean up the generated files
after test.
caplog : pytest.fixture
Pytest fixture variable, used to capture the log messages during the test.
"""
# test plugin reader
test = ReaderTest(nxdl, reader_name, files_or_dir, tmp_path, caplog)
test.convert_to_nexus()
# test.convert_to_nexus(caplog_level="ERROR", ignore_undocumented=True)
# Use `ignore_undocumented` to skip undocumented fields
# caplog_level can be "ERROR" or "WARNING"
test.check_reproducibility_of_nexus()
# Here, you can also pass `ignore_lines` (a list) or `ignore_sections` (a dict)
# if you want to ignore certain lines or lines within a section in the comparison
# of the log files of the reference -nxs file and the one created in the test.
Alongside the test data in test/data
, it is also possible to add other types of test data inside the test directory of the plugin.
You can also pass additional parameters to test.convert_to_nexus
:
-
caplog_level
(str): Can be either "ERROR" (by default) or "warning". This parameter determines the level at which the caplog is set during testing. If it is "WARNING", the test will also fail if any warnings are reported by the reader. -
ignore_undocumented
(boolean): If true, the test skipts the verification of undocumented keys. Otherwise, a warning massages for undocumented keys is raised
How to write an integration test for a NOMAD example in a reader plugin¶
It is also possible to ship examples for NOMAD directly with the reader plugin. As an example, pynxtools-mpes
comes with its own NOMAD example (see here) using the ExampleUploadEntryPoint of NOMAD (see here for more documentation).
The testing
sub-package of pynxtools
provides two functionalities for testing the ExampleUploadEntryPoint
defined in a pynxtools
plugin:
1) Test that the ExampleUploadEntryPoint can be properly loaded
2) Test that the schemas and files in the example folder(s) can be parsed by NOMAD
We will write a test for a pynxtools_foo_example_entrypoint
defined in the pyproject.toml file of a demo pynxtools-FOO
(here the actual example data resides in the folder src/pynxtools_foo/nomad/examples
):
[project.entry-points.'nomad.plugin']
pynxtools_foo_example = "pynxtools_foo.nomad.entrypoints:pynxtools_foo_example_entrypoint"
from nomad.config.models.plugins import ExampleUploadEntryPoint
pynxtools_foo_example_entrypoint = ExampleUploadEntryPoint(
title="My example upload",
description="""
This is an example upload for the pynxtools-FOO package.
""",
plugin_package="pynxtools_foo",
resources=["nomad/examples/*"],
)
pynxtools_foo_example_entrypoint
could look like this:
import nomad
from pynxtools.testing.nomad_example import (
get_file_parameter,
parse_nomad_examples,
example_upload_entry_point_valid,
)
from pynxtools_foo.nomad.entrypoints import pynxtools_foo_example_entrypoint
EXAMPLE_PATH = os.path.join(
os.path.dirname(__file__),
"..",
"src",
"pynxtools_foo",
"nomad",
"examples",
)
@pytest.mark.parametrize(
"mainfile",
get_file_parameter(EXAMPLE_PATH),
)
def test_parse_nomad_examples(mainfile):
"""Test if NOMAD examples work."""
archive_dict = parse_nomad_examples(mainfile)
# Here, you can also implement more logic if you know the contents of the archive_dict
@pytest.mark.parametrize(
("entrypoint", "example_path"),
[
pytest.param(
pynxtools_foo_example_entrypoint,
EXAMPLE_PATH,
id="pynxtools_foo_example",
),
],
)
def test_example_upload_entry_point_valid(entrypoint, example_path):
"""Test if NOMAD ExampleUploadEntryPoint works."""
example_upload_entry_point_valid(
entrypoint=entrypoint,
example_path=example_path,
)